Open
Conversation
Collaborator
|
Yeah, this fixes quest triggers that are on the world map but "belong" to an island. BUT we have to make sure that those coordinates don't break when making the map bigger. We might also want to introduce a minimum session size. |
Collaborator
Author
|
Yes, all position updates must either be prevented or be propagated to all relevant objects. I'll look into that later. |
Collaborator
|
Good idea. Though it might be difficult to identify the relevant objects. Because simple locations might be fine but paths etc get harder. And island rotation would make extra difficult 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a toggle to lock islands. Locked islands can neither be moved nor have any of their properties changed. This prevents moving islands by accident.
Secondly it serves as a foundation for supporting custom Arctic and Enbesa. Due to the presence of custom triggers and other GameObjects, changing certain islands would break quests in those regions. Locking them does not solve all issues but it is a first step in the right direction.
In the future warning messages should be added if the user attempts to unlock an island containing GameObjects.