Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Docker publish GitHub Actions workflow to use a different API base URL for builds originating from the main branch.
Changes:
- Switch
VITE_API_URLformainbuilds frombackoffice-api.projetodesenvolve.devtobackoffice-api.projetodesenvolve.online.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
35
to
39
| if [[ "${GITHUB_REF_NAME}" == "main" ]]; then | ||
| echo "VITE_API_URL=https://backoffice-api.projetodesenvolve.dev" >> "$GITHUB_ENV" | ||
| echo "VITE_API_URL=https://backoffice-api.projetodesenvolve.online" >> "$GITHUB_ENV" | ||
| else | ||
| echo "VITE_API_URL=https://backoffice-api.projetodesenvolve.dev" >> "$GITHUB_ENV" | ||
| fi |
There was a problem hiding this comment.
The workflow runs on multiple branches (production/prd/homolog/hml/develop/dev) and tags (v*), but VITE_API_URL is only switched for main; all other refs (including production releases and tag builds) will be built against the .dev API. Consider mapping the URL based on GITHUB_REF_NAME (and github.ref_type/tag builds) so production and staging branches/tags point to the correct API endpoint(s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.