create TLS client & server with full set of arguments#52
Open
CodiePP wants to merge 1 commit intoanmonteiro:masterfrom
Open
create TLS client & server with full set of arguments#52CodiePP wants to merge 1 commit intoanmonteiro:masterfrom
CodiePP wants to merge 1 commit intoanmonteiro:masterfrom
Conversation
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
Owner
|
My rationale for having a limited set of options for these default handlers is that you can always "jailbreak" by using your own |
Author
true. Since the arguments are optional they could be put on the default handler too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Diemand codieplusplus@apax.net
This change allows to pass in more arguments to the basic
Tls_iofunctions to setup itsTls.Config.This allows to more finegrained control the TLS handshake and improve security.
An example of its usage is in: https://github.com/CodiePP/ml-grpc-examples
(an accompanying PR is submitted to https://github.com/anmonteiro/ocaml-h2)