FEAT(install script): Add glibc version check on linux #4484
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GithubAnon0000
changed the title
Collaborator
|
The launcher checks the glibc version by the way (see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://forums.ankiweb.net/t/installer-overwrote-working-install-with-incompatible-binary/68022?u=anon_0000
This checks that the users glibc version is supported and aborts otherwise. That way the older, working installation of the user (installed with the official install script) won't be overwritten with the new, unsupported version.
Caveat: this makes maintainance a bit more difficult as now the
MINIMUM_REQUIRED_GLIBC_VERSIONneeds to be updated. Maybe it can be automated. Or maybe the version bump of minimum required glibc is unfrequent enough that we don't mind.