Fix #19225: refresh queue on note edit #20114
Open
+69
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
what do you mean by that? |
Contributor
Author
|
When we edit the note, the card's mod time changes in the DB, but the scheduler's queue cache is still holding the old state. If we don't force refresh it, backend detects this mismatch (DB vs Cache) when we try to undo, it triggers the "card modified without updating queue" error. |
Member
|
A test would make this easier to review |
Prevent 'card modified without updating queue' error by refreshing state when note text changes.
Ayush-Patel-56
force-pushed
the
fix/19225-update-queue-on-note-edit
branch
from
0d22112 to
c13d904
Compare
Contributor
Author
|
Added the test case in ReviewerViewModelTest.kt. It verifies that the card state refreshes correctly after a template modification |
david-allison
requested changes
Jan 16, 2026
|
|
||
| @Before | ||
| fun setup() { | ||
| Dispatchers.setMain(StandardTestDispatcher()) |
| val viewModel = ReviewerViewModel(handle) | ||
|
|
||
| advanceUntilIdle() | ||
| advanceRobolectricLooper() |
| val notetype = note.notetype | ||
| val tmpls = notetype.templates | ||
| val tmpl = tmpls.first() | ||
| tmpl.qfmt = tmpl.qfmt + " Modified" |
| val newCard = viewModel.currentCard.await() | ||
| assertThat("Card should be refreshed (new instance)", newCard, not(sameInstance(card))) | ||
|
|
||
| viewModel.answerCard(Rating.GOOD) |
Member
There was a problem hiding this comment.
You should probably be asserting something. If not: assertDoesNotThrow
Comment on lines
+43
to
+48
| val card = viewModel.currentCard.await() | ||
| val note = card.note() | ||
| val notetype = note.notetype | ||
| val tmpls = notetype.templates | ||
| val tmpl = tmpls.first() | ||
| tmpl.qfmt = tmpl.qfmt + " Modified" |
Member
There was a problem hiding this comment.
Very verbose, how about:
viewModel.currentCard.await().noteType().update {
templates.first().qfmt += " Modified"
}
david-allison
added
the
Needs Author Reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19225: Refresh queue on note edit
Issue
Fixes #19225
Problem
Editing a note or template in the new reviewer desyncs the backend queue state. Attempting to Undo afterwards trigger a
bug: card modified without updating queueerror and messes up the review counts.Solution
Force updateCurrentCard() when
OpChanges.noteTextfires. This ensures we refresh the queue state from the backend whenever the card content changes.Testing
Added ReviewerViewModelTest which reproduces the issue by simulating a template edit and verifying that the
currentCardinstance is correctly refreshed from the backend.ReviewerViewModelTest.editing note template updates queue state preventing undo errorpasses.