Skip to content

Conversation

@Sagar0-0
Copy link
Contributor

Purpose / Description

Fixes #17967 , keyboard closes on IME_DONE clicked

Fixes

Fixes #17967

Approach

Solved in the library by adding IME action callback

How Has This Been Tested?

Tested manually

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! In my opinion you have to crosslink your upstream work in order to let it shine :-)

ByteHamster/SearchPreference#38

https://github.com/ByteHamster/SearchPreference/releases/tag/2.7.1

well done

@mikehardy mikehardy added the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 15, 2025
@mikehardy mikehardy added this pull request to the merge queue Feb 15, 2025
Merged via the queue into ankidroid:main with commit c6c480c Feb 15, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Feb 15, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 15, 2025
@david-allison
Copy link
Member

Hi there @Sagar0-0! This is the OpenCollective Notice for PRs merged from 2025-02-01 through 2025-02-28

If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Close Keyboard on IME DONE

3 participants