Skip to content
This repository was archived by the owner on May 5, 2020. It is now read-only.

Conversation

@vatsalkul
Copy link
Member

Description

I have organised the constants in Utilities/Strings.swift into appropriate enums.
It will result in efficient access and identification of data throughout the app.

Fixes #222

Type of Change:

  • Code

Code/Quality Assurance Only

  • Code Refactoring

How Has This Been Tested?

All the functionality of app is working and tased on iPhone simulator.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

Made enums in order to access strings
@sunjunkie
Copy link
Contributor

I’m still thinking about this. The enum naming is not ideal.

@vatsalkul
Copy link
Member Author

vatsalkul commented Mar 3, 2020

As I gone through the Strings.swift file, I also noticed that there is a scope of organising strings in the related groups. After all, It depends upon the developer what kind of style they want to follow. 😇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Strings.swift to group strings in enums and update accessors throughout the app.

2 participants