Closed
Conversation
Previously, ResetTask would silently succeed even if a task didn't exist or was in a different environment. This could lead to confusion where users think a reset succeeded when it didn't. Changes: - Add ResetStatus enum and ResetResult/ResetTasksResult types - Update ResetTasksByIds to return ResetTasksResult with detailed status for each task (Success, NotFound, DifferentEnv, NotTerminal, Error) - Update ResetTask to check the result status and return appropriate errors for NotFound and DifferentEnv cases - Add helper methods ResetCount() and Errors() to ResetTasksResult - Update interface and documentation to reflect new behavior - Add comprehensive tests documenting the new validation behavior Breaking change: ResetTasksByIds now returns ResetTasksResult instead of (int, error). This is acceptable as there are no production users yet. The new design is more efficient (no extra queries) and provides better visibility into what happened to each task during bulk operations. Fixes issue where resetting a task in a different environment would silently succeed without actually resetting anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ResetTask would silently succeed even if a task didn't exist or was in a different environment. This could lead to confusion where users think a reset succeeded when it didn't.
Changes:
Breaking change: ResetTasksByIds now returns ResetTasksResult instead of (int, error). This is acceptable as there are no production users yet.
The new design is more efficient (no extra queries) and provides better visibility into what happened to each task during bulk operations.
Fixes issue where resetting a task in a different environment would silently succeed without actually resetting anything.