Editjoin disk #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

anhaidgroup wants to merge 33 commits into anhaidgroup:master from Bhargav145:editjoin_disk

Owner

anhaidgroup commented Jul 24, 2018

Pull request for the code from Bhargav and Ankit

tangirb145 and others added 30 commits

March 2, 2018 07:38


          Added the edit distance join disk cython file and corresponding pytho…

9a55aa0

…n file. The output is not in memory instead in a

file.


          1st commit to remote

1ff81f3


          2nd push to origin with all the files.

93bdeca


          Added functionality of glob for creating a file anywhere.

b33d3be


          Removing extra print statements

514beca


          Added validation to the attributes datalimit and path in Utils.

34d546a


          Validating the attributes sata_limit, path

ed517b6


          Merging ankit changes and my changes.

554df1a

Merge branch 'editjoin_disk' of github.com:Bhargav145/py_stringsimjoin into editjoin_disk


          Handling missing values and cleaning code

3fb42b4


          Adding header to the output file and cleaned code

4ce2f79


          Added comments

3d90a61


          Created edit_dist_join_disk test file

ae0e0b0


          Removing output file before creating new and cleaned code.

c488139


          Modified Comment

f536560


          Modified Default value of data_limit to 100K


          1. Added new parameter output_file_path (Absolute path for output fil…

cb67de1

…e) [User Configurable]

2. Added validation function for output_file_path
3. Scaled down the data limit with respect to the number of cores available.


          Updated function Doc String

3e5cc1f


          There is a possibility that memory goes out of bound during calculati…

02d59af

…on of missing values,so added disk version for adding missing values.


          Modifying variable name and return value.

a5647d2


          Create CodeReviewComments

19f0f9b


          Rename CodeReviewComments to CodeReviewComments.md

5d2db92


          Update CodeReviewComments.md

a64b34f


          Update CodeReviewComments.md


          Modifying the code as per comments received after code review.

a981c76


          Merge remote-tracking branch 'origin/editjoin_disk' into editjoin_disk

1b8ae14


          Added changes to test the edit distance join disk.

f9ebbd7

#TODO.
1. Need to read the output file to compare the results with the expected one.


          Added argument checking testcases.

85c8ac7


          Fixed File name

30a6abf


          Fixed File name

bc8463e


          Added more test cases and modified intermediate file writing code.

767b9a8

ankitjain64 added 3 commits

May 10, 2018 16:37


          Added more test cases for data limits, multiprocessing and output fil…

9837f66

…e paths


          Added comments and modified output file name

79cfe61


          Merged and commited the changes done by @bharghav.

adec91c

coveralls commented Jul 24, 2018

Coverage increased (+0.4%) to 76.525% when pulling adec91c on Bhargav145:editjoin_disk into 624212b on anhaidgroup:master.

4 similar comments

coveralls commented Jul 24, 2018

Coverage increased (+0.4%) to 76.525% when pulling adec91c on Bhargav145:editjoin_disk into 624212b on anhaidgroup:master.

coveralls commented Jul 24, 2018

Coverage increased (+0.4%) to 76.525% when pulling adec91c on Bhargav145:editjoin_disk into 624212b on anhaidgroup:master.

coveralls commented Jul 24, 2018

Coverage increased (+0.4%) to 76.525% when pulling adec91c on Bhargav145:editjoin_disk into 624212b on anhaidgroup:master.

coveralls commented Jul 24, 2018 •

edited

Loading

Coverage increased (+0.4%) to 76.525% when pulling adec91c on Bhargav145:editjoin_disk into 624212b on anhaidgroup:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet