Skip to content

fix: adjust distance limits for city 3D component interaction #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manfredsteyer merged 2 commits into from
Sep 30, 2025
Merged

fix: adjust distance limits for city 3D component interaction #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa85f4c
fix: adjust distance limits for city 3D component interaction
msari-ipe-ext-1 Sep 29, 2025
56077cd
fix: demo user assignment logic in calcTeamAlignment function
msari-ipe-ext-1 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions .detective/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
{
"scopes": [
"apps/backend/src/infrastructure",
"apps/backend/src/mcp",
"apps/backend/src/model",
"apps/backend/src/options",
"apps/backend/src/services",
"apps/backend/src/utils",
"apps/frontend"
],
"groups": ["apps/backend/src", "apps/backend", "apps"],
"scopes": ["apps"],
"groups": [],
"entries": [],
"filter": {
"files": [],
Expand Down
15 changes: 7 additions & 8 deletions apps/backend/src/services/team-alignment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,18 @@ export async function calcTeamAlignment(

if (options.demoMode) {
count++;
if (count % 4 === 1) {
userName = 'Max Muster';
} else if (count % 4 === 2) {
userName = 'John Doe';
} else if (count % 4 == 3) {
userName = 'Jane Doe';
}
const demoUsers = ['Max Muster', 'John Doe', 'Jane Doe', 'Maria Muster'];
userName = demoUsers[(count - 1) % demoUsers.length];
}

userName = config.aliases?.[userName] || userName;

const emailLower = (entry.header.email || '').toLowerCase();
const stableUserKey = byUser ? emailLower || userName : userName;
const stableUserKey = byUser
? options.demoMode
? userName
: emailLower || userName
: userName;

if (!userKeyToDisplay[stableUserKey]) {
userKeyToDisplay[stableUserKey] = userName;
Expand Down
4 changes: 2 additions & 2 deletions apps/frontend/src/app/features/hotspot-city/city3d.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class City3DComponent implements OnChanges, OnDestroy {
private targetRotationY = 0;
private targetPanX = 0;
private targetPanZ = 0;
private distance = 100;
private distance = 20;

ngOnChanges(changes: SimpleChanges): void {
if (changes['items'] || changes['mode']) {
Expand Down Expand Up @@ -443,7 +443,7 @@ export class City3DComponent implements OnChanges, OnDestroy {
if (!this.renderer || !target || !this.renderer.domElement.contains(target))
return;
this.distance += event.deltaY * 0.05;
this.distance = Math.max(20, Math.min(4000, this.distance));
this.distance = Math.max(0, this.distance);
event.preventDefault();
}

Expand Down