Skip to content

Conversation

@andyrewlee
Copy link
Owner

@andyrewlee andyrewlee commented Jan 28, 2026

After hours of computer sleep, old agent tabs would not respond to keyboard input because SendString() errors were silently discarded.

Changes:

  • Check SendString() errors in tab actor and direct fallback paths
  • Mark tab as disconnected (Running=false) when write fails
  • Send TabInputFailed message to show toast notification
  • Add visual indicator (dimmed tab with empty circle) for disconnected tabs

Users can still scroll through terminal history after disconnection.


Open with Devin

After hours of computer sleep, old agent tabs would not respond to
keyboard input because SendString() errors were silently discarded.

Changes:
- Check SendString() errors in tab actor and direct fallback paths
- Mark tab as disconnected (Running=false) when write fails
- Send TabInputFailed message to show toast notification
- Add visual indicator (dimmed tab with empty circle) for disconnected tabs

Users can still scroll through terminal history after disconnection.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional flags.

Open in Devin Review

Follow-up to efd01d4 to handle remaining SendString errors:
- model_input.go: ctrl+[ escape key
- model_monitor.go: paste and keyboard input in monitor mode
- model_tabs.go: response writer callback and SendToTerminal helper
- terminal.go: sidebar paste and keyboard input
- terminal_pty.go: sidebar SendToTerminal helper

All paths now log warnings and mark terminals as disconnected on failure.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@andyrewlee andyrewlee merged commit 7a4ff58 into main Jan 28, 2026
1 check passed
@andyrewlee andyrewlee deleted the idle branch January 28, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants