Add path migration and safety checks

[andyrewlee]

---

[devin-ai-integration]

Devin Review found 2 potential issues.

View issues and 5 additional flags in Devin Review.

[devin-ai-integration]

Devin Review found 1 new potential issue.

View issue and 7 additional flags in Devin Review.

[devin-ai-integration]

🔴 Fallback logic overwrites successfully migrated paths when partial migration fails

When workspaces migration succeeds but metadata migration fails, the fallback logic incorrectly reverts BOTH paths to legacy locations, causing data loss.

Click to expand

Scenario

1. RunMigrations() successfully copies workspaces (MigratedWorkspacesRoot = true)
2. Metadata migration fails (e.g., permission error), setting result.Error
3. In app.go:223-236, when migrationResult.Error != nil, the fallback logic checks if legacy paths exist and unconditionally falls back to them
4. Even though workspaces were successfully migrated to the new location, cfg.Paths.WorkspacesRoot is reset to the legacy path

Code flow:

// migrate.go:41 - workspaces migration succeeds
result.MigratedWorkspacesRoot = migrated  // true

// migrate.go:48-50 - metadata migration fails
if err != nil {
    result.Error = err
    return result  // MigratedWorkspacesRoot is still true
}

// app.go:223-229 - fallback ignores successful migration
if migrationResult.Error != nil {
    // Falls back BOTH paths, even though workspaces succeeded
    if info, err := os.Stat(legacyWorkspacesRoot); err == nil && info.IsDir() {
        cfg.Paths.WorkspacesRoot = legacyWorkspacesRoot  // WRONG!
    }
}

Impact

The application will read from the legacy workspaces directory instead of the newly migrated one, potentially causing:

• Users see stale/old workspace data
• New changes are written to wrong location
• Data inconsistency between workspaces and metadata

Recommendation: Check migrationResult.MigratedWorkspacesRoot before falling back: only fall back to legacy workspaces path if the workspaces migration did NOT succeed. Similarly for metadata.

---

Was this helpful? React with 👍 or 👎 to provide feedback.