Fix deprecation warnings introduced in PyTorch version >=1.10#2
Open
JulianKu wants to merge 1 commit intoandyljones:masterfrom
Open
Fix deprecation warnings introduced in PyTorch version >=1.10#2JulianKu wants to merge 1 commit intoandyljones:masterfrom
JulianKu wants to merge 1 commit intoandyljones:masterfrom
Conversation
Changes in `common.h` and `kernels.cu` regarding deprecation of `AutoNonVariableTypeMode` according to [this migration guide](https://pytorch.org/cppdocs/notes/inference_mode.html#migration-guide-from-autononvariabletypemode) Changes in `lstm.py` regarding deprecation of `__floordiv__` according to warning as given [here](https://pytorch.org/docs/1.10/generated/torch.floor_divide.html?highlight=floor_divide#torch.floor_divide)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using megastep with PyTorch 1.10 introduces 2 deprecation warnings, which could lead to errors in future PyTorch versions.
Consequently, this pull request fixes the issues applying the officially recommended alternatives:
torch.floor_dividefunction used by a tensor's__floordiv__method and thus also invoked by the//operator is deprecated. In megastep, it is used indemo/lstm.py(l. 57) and has been replaced applying the official recommendation by using usetorch.div()withrounding_mode='floor'.AutoNonVariableTypeModeused in kernels.cu and corresponding header is deprecated. The migration guide recommends replacing it withc10::InferenceMode.