Updated TimeLineSettings to Use since_id#9
Open
dpparekh wants to merge 2 commits intoandyhutch77:masterfrom
Open
Updated TimeLineSettings to Use since_id#9dpparekh wants to merge 2 commits intoandyhutch77:masterfrom
dpparekh wants to merge 2 commits intoandyhutch77:masterfrom
Conversation
I updated the code to allow to pull timeline from a specific unqiue tweet id.
Updated timelinesettings to use since_id only if it is available.
Owner
|
Thanks, I'll add this to the next set of changes released. I think I can do it in a way that is more configurable but will keep your existing changes. 👍 Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per our discussion, I updated the timeline settings to take since_id. This will allow me to provide a minimum/since "tweet" id that I want to get data from.
The suggestion you had made to update searchsettings wouldn't have worked since per your comment earlier Twitter API doesn't allow one to search based on user for that you have to use timeline and timeline doesn't provide a way to get Tweets based on date, you have to use since_id.
Look it over and let me know what you think.
Dhaval