This repository was archived by the owner on Jun 10, 2019. It is now read-only.
Add PNIN as a system manifest parameter. #485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: andsens#349 Adds a new boolean parameter indicating weather to use PNIN or not to the system section of the manifest. The default, False enables tasks for extlinux and grub to pass net.ifnames=0 biosdevnames=0 parameters to the kernel. Previously for grub PNIN was disabled for stretch and later. This remains the default but setting system.pnin True will allow the behavior to be overridden. The additional parameters have no effect on earlier releases are passed regardless. Extlinux had no prior special behavior, it now mirrors grub.
Contributor
Author
|
PR description edited to more accurately reflect the implementation, I changed the behavior before submitting without changing the commit message. Edit: The parameters are only passed to extlinux if Feel free to edit the commit message while merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #349
Adds a new boolean parameter indicating weather to use PNIN or not to
the system section of the manifest.
The default, False enables tasks for extlinux and grub to pass
net.ifnames=0 biosdevnames=0 parameters to the kernel.
Previously for grub PNIN was disabled for stretch and later. This
remains the default but setting system.pnin True will allow the behavior
to be overridden. Extlinux had no prior special behavior,
it now mirrors grub.