(not compiling) grab an IconSet from a remote location#4
Open
drzraf wants to merge 1 commit intoandroidsoft-org:masterfrom
Open
(not compiling) grab an IconSet from a remote location#4drzraf wants to merge 1 commit intoandroidsoft-org:masterfrom
drzraf wants to merge 1 commit intoandroidsoft-org:masterfrom
Conversation
…tion and store it to cache afterward. * Internal Storage => no additionnal permission * Fetch from one URL (a XML file) so anyone can create/host its sets * Expected XML would contains: <title>Title</title> <verso>The URL of the PNG file defining the verso</verso> <images> <image>The URL of a PNG file for an icon</verso> [...] </images> ATM the Tile* class use int from Resources rather than Drawable, that may need to be changed.
Author
|
ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let me do this PR in order to open a discussion for such a feature : fetching a set of memory cards from remote URL.
Objective: adding new sets made easy and flexible
One the question (beside the feature itself), is the use of
R.Drawable(int) ratherBitmapDrawable. I'd appreciate opinions before making such an intrusive type change.(I'm pretty much inexperienced in Android dev')
Commit text:
ATM the Tile* class use int from Resources rather than Drawable, that may need to
be changed.