-
Notifications
You must be signed in to change notification settings - Fork 22
Update static assets URLs #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yrezgui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a potential issue with a static video asset by updating its URL. The change ensures that the 'Big Buck Bunny' video, used in the RoadReels sample application, can be streamed and played without interruption by directing to a more current and reliable Google Cloud Storage path. This is a crucial maintenance update to prevent broken media links and maintain the functionality of the sample. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the URL for a static media asset across three PlayerViewModel.kt files. The change is a straightforward update to a new asset location. My review focuses on improving code maintainability by suggesting the extraction of the hardcoded URL into a named constant. This is a common best practice that makes the code cleaner and easier to update in the future.
| val MEDIA_SOURCE = | ||
| MediaItem.fromUri("https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4") | ||
| MediaItem.fromUri("https://storage.googleapis.com/androiddevelopers/samples_assets/gtv-videos-bucket/sample/BigBuckBunny.mp4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability and to avoid hardcoded values, it's a good practice to extract this URL into a const val. This makes it easier to find and update in the future.
private const val BIG_BUCK_BUNNY_URL = "https://storage.googleapis.com/androiddevelopers/samples_assets/gtv-videos-bucket/sample/BigBuckBunny.mp4"
val MEDIA_SOURCE =
MediaItem.fromUri(BIG_BUCK_BUNNY_URL)| val MEDIA_SOURCE = | ||
| MediaItem.fromUri("https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4") | ||
| MediaItem.fromUri("https://storage.googleapis.com/androiddevelopers/samples_assets/gtv-videos-bucket/sample/BigBuckBunny.mp4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability and to avoid hardcoded values, it's a good practice to extract this URL into a const val. This makes it easier to find and update in the future.
private const val BIG_BUCK_BUNNY_URL = "https://storage.googleapis.com/androiddevelopers/samples_assets/gtv-videos-bucket/sample/BigBuckBunny.mp4"
val MEDIA_SOURCE =
MediaItem.fromUri(BIG_BUCK_BUNNY_URL)| val MEDIA_SOURCE = | ||
| MediaItem.fromUri("https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4") | ||
| MediaItem.fromUri("https://storage.googleapis.com/androiddevelopers/samples_assets/gtv-videos-bucket/sample/BigBuckBunny.mp4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability and to avoid hardcoded values, it's a good practice to extract this URL into a const val. This makes it easier to find and update in the future.
private const val BIG_BUCK_BUNNY_URL = "https://storage.googleapis.com/androiddevelopers/samples_assets/gtv-videos-bucket/sample/BigBuckBunny.mp4"
val MEDIA_SOURCE =
MediaItem.fromUri(BIG_BUCK_BUNNY_URL)
No description provided.