Skip to content

Offscreen bitmap renderer: #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riggaroo merged 3 commits into from
Aug 11, 2025
Merged

Offscreen bitmap renderer: #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0a8078
Revert to not re-using the surface due to crashes with `android.view.…
riggaroo Aug 11, 2025
7c28343
Remove fake dispose/init methods
riggaroo Aug 11, 2025
f81c2ad
Cleanup
riggaroo Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...testing/src/main/java/com/android/developers/testing/util/FakeComposableBitmapRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ import androidx.core.graphics.createBitmap
import com.android.developers.androidify.customize.ComposableBitmapRenderer

class FakeComposableBitmapRenderer : ComposableBitmapRenderer {
override fun initialize() {
}

override fun dispose() {
}

override suspend fun renderComposableToBitmap(
canvasSize: Size,
Expand Down
45 changes: 16 additions & 29 deletions ...src/main/java/com/android/developers/androidify/customize/ComposableBitmapRendererImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import android.graphics.Bitmap
import android.graphics.SurfaceTexture
import android.hardware.display.DisplayManager
import android.hardware.display.VirtualDisplay
import android.util.Log
import android.view.Display
import android.view.Surface
import android.view.ViewGroup
Expand Down Expand Up @@ -58,9 +57,6 @@ import javax.inject.Inject
import javax.inject.Singleton

interface ComposableBitmapRenderer {
fun initialize()

fun dispose()

suspend fun renderComposableToBitmap(canvasSize: Size, composableContent: @Composable () -> Unit): Bitmap?
}
Expand All @@ -79,34 +75,25 @@ interface ComposableBitmapRenderer {
*/
@Singleton
class ComposableBitmapRendererImpl @Inject constructor(private val application: Application) : ComposableBitmapRenderer {
private val texture = SurfaceTexture(false)
private val surface = Surface(texture)
private var virtualDisplay: VirtualDisplay? = null

override fun initialize() {
virtualDisplay =
(application.getSystemService(DISPLAY_SERVICE) as DisplayManager).createVirtualDisplay(
"virtualDisplay",
1,
1,
72,
surface,
DisplayManager.VIRTUAL_DISPLAY_FLAG_OWN_CONTENT_ONLY,
)
}

override fun dispose() {
virtualDisplay?.release()
private suspend fun <T> useVirtualDisplay(callback: suspend (display: Display) -> T): T? {
val texture = SurfaceTexture(false)
val surface = Surface(texture)
val virtualDisplay: VirtualDisplay? =
(application.getSystemService(DISPLAY_SERVICE) as DisplayManager).createVirtualDisplay(
"virtualDisplay",
1,
1,
72,
surface,
DisplayManager.VIRTUAL_DISPLAY_FLAG_OWN_CONTENT_ONLY,
)

val result = callback(virtualDisplay!!.display)
virtualDisplay.release()
surface.release()
texture.release()
}

private suspend fun <T> useVirtualDisplay(callback: suspend (display: Display) -> T): T? {
if (virtualDisplay == null) {
Log.e("OffscreenBitmapManager", "virtualDisplay is null")
initialize()
}
return callback(virtualDisplay!!.display)
return result
}

override suspend fun renderComposableToBitmap(canvasSize: Size, composableContent: @Composable () -> Unit): Bitmap? {
Expand Down
1 change: 0 additions & 1 deletion ...lts/src/main/java/com/android/developers/androidify/customize/CustomizeExportViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ class CustomizeExportViewModel @Inject constructor(

override fun onCleared() {
super.onCleared()
composableBitmapRenderer.dispose()
}
fun setArguments(
resultImageUrl: Bitmap,
Expand Down