Skip to content

Introduce Modifier.onVisibilityChanged #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riggaroo merged 1 commit into from
Jun 17, 2025
Merged

Introduce Modifier.onVisibilityChanged #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions feature/home/src/main/java/com/android/developers/androidify/home/HomeScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ import androidx.compose.ui.graphics.graphicsLayer
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.graphics.vector.rememberVectorPainter
import androidx.compose.ui.layout.onLayoutRectChanged
import androidx.compose.ui.layout.onVisibilityChanged
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.platform.LocalInspectionMode
import androidx.compose.ui.platform.LocalView
Expand Down Expand Up @@ -541,9 +542,10 @@ private fun VideoPlayer(
Modifier
.background(MaterialTheme.colorScheme.surfaceContainerLowest)
.onVisibilityChanged(
containerWidth = LocalView.current.width,
containerHeight = LocalView.current.height,
) { fullyVisible -> videoFullyOnScreen = fullyVisible }
minDurationMs = 100,
minFractionVisible = 1f
)
{ fullyVisible -> videoFullyOnScreen = fullyVisible }
.then(modifier),
) {
player?.let { currentPlayer ->
Expand Down Expand Up @@ -579,16 +581,3 @@ private fun VideoPlayer(
}
}
}

fun Modifier.onVisibilityChanged(
containerWidth: Int,
containerHeight: Int,
onChanged: (visible: Boolean) -> Unit,
) = this then Modifier.onLayoutRectChanged(100, 0) { layoutBounds ->
onChanged(
layoutBounds.boundsInRoot.top > 0 &&
layoutBounds.boundsInRoot.bottom < containerHeight &&
layoutBounds.boundsInRoot.left > 0 &&
layoutBounds.boundsInRoot.right < containerWidth,
)
}