Dagger @Module cleanup
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace unnecessary `@Provides` with `@Binds` - Add missing `@Inject constructor`s - Lower visibility of classes and fields where modularization permits - Convert raw `Context` and `@ApplicationContext` usages with explicit `Application`
dturner
approved these changes
Jul 8, 2025
Contributor
dturner
left a comment
dturner
left a comment
There was a problem hiding this comment.
Nice work @SimonMarquis :)
* main: (56 commits) Move to LocalFileProvider rather than ImageGenerationRepository Change the shape to be the Material one instead Add fake to Android tests Fix naming Create Fake for testing Fix code review comments Add comments to clarify the logic Use ImageGenerationRepository to process the image dragged to Androidify Move DropBehaviour to be injected Add export services for instrumented tests too. Update README.md Fix build error for accessing token Remove local google-services.json file, and pull debug file down in build_and_test.yml workflow instead. Add to .gitignore Clean imports Enables Dropping an image into Androidify Update video player logic: now it pauses also when another window is occluding it (in multi-window mode) Update video player logic: now it pauses also when another window is occluding it (in multi-window mode) Revert the bot image desc change Revert the video semantics desc change Improve the layout of the footer buttons ...
Contributor
|
@riggaroo The CI build is failing with |
Contributor
Author
|
The |
Collaborator
|
This PR should hopefully fix this - #78 - its due to it being a fork with the author not having access to the secrets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Provideswith@Binds@Inject constructorsContextand@ApplicationContextusages with explicitApplication