Skip to content

Update continuous.cfg #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riggaroo merged 1 commit into from
Sep 12, 2025
Merged

Update continuous.cfg #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kokoro/gcp_ubuntu_docker/continuous.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
build_file: "androidify/kokoro/gcp_ubuntu_docker/kokoro_build_release_mobile.sh"
build_file: "androidify/kokoro/gcp_ubuntu_docker/kokoro_build_mobile_release.sh"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new script name kokoro_build_mobile_release.sh is inconsistent with the script it executes (build_release_mobile.sh). The previous name, kokoro_build_release_mobile.sh, mirrored the wrapped script's name, which is a good practice for readability and maintainability. To maintain this consistency, it's recommended to use the previous name. This would require this change to be reverted and the script file to be renamed accordingly.

build_file: "androidify/kokoro/gcp_ubuntu_docker/kokoro_build_release_mobile.sh"

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The path to the build script appears to be incorrect. Based on the repository's file structure, the path should not be prefixed with androidify/. This will likely cause the build to fail because the script will not be found at the specified location.

build_file: "kokoro/gcp_ubuntu_docker/kokoro_build_mobile_release.sh"


action {
define_artifacts {
Expand Down