Change EmailViewResult to use the final Parser output...#135
Open
CodeAnimal wants to merge 1 commit intoandrewdavey:masterfrom
Open
Change EmailViewResult to use the final Parser output...#135CodeAnimal wants to merge 1 commit intoandrewdavey:masterfrom
CodeAnimal wants to merge 1 commit intoandrewdavey:masterfrom
Conversation
…e result output. EmailViewResult now gives an accurate output if a custom parser is used (e.g. when inlining the CSS), as it now uses the MailMessage body as the output, rather than the Renderer's result. Now also checks for alternative views if no format query is given, to render emails with embedded images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...rather than the result output.
EmailViewResult now gives an accurate output if a custom parser is used (e.g. when inlining the CSS), as it now uses the MailMessage body as the output, rather than the Renderer's result.
Now also checks for alternative views if no format query is given, to render emails with embedded images.