Open
Conversation
When implementing a custom EmailParser or EmailViewRenderer it is often useful to be able to derive the class to tweak the default implementation, and being able to override the interface methods on the base class allows this to be done effectively.
…nternal. Change the accessibility level to protected internal to make implementing custom IEmailParser and IEmailViewRenderer implementations easier, as access to the ImageEmbedder field is needed to render embedded images. An alternative could be to set the level to public, allowing implementing customer renders even easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the accessibility levels of the
EmailParserandEmailViewRendererclasses to be virtual, to aid in creating custom implementations that tweak the function of the defaultEmailParserandEmailViewRendererimplementations.Also update the
Email.ImageEmbedderfield to be protected internal to allow make implementing customerIEmailParsers andIEmailViewRenderers a little easier, as it needs access to theImageEmbedderfield to get the embedded images, this way now we can create a customerEmailBaseclass that inherits the Email class that exposes theImageEmbedderfield internally.