Change access of member ImageEmbedder on Email object from internal t…#119
Open
MelzerJ wants to merge 1 commit intoandrewdavey:masterfrom
Open
Change access of member ImageEmbedder on Email object from internal t…#119MelzerJ wants to merge 1 commit intoandrewdavey:masterfrom
MelzerJ wants to merge 1 commit intoandrewdavey:masterfrom
Conversation
…o public We need to extend the existing functionality of the EmailParser with different handling of the Postal Header and integrate functionality to move css styles inline. Therefore we need to write our own EmailParser implementing IEmailParser Interface. Unfortunately with the internal on the Email object we can't use the ImageEmbedder in our Parser. To ensure extensibility of the EmailParser the ImageEmbedder should be accessable.
|
+1 from me for this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our project we need to extend the existing functionality of the EmailParser with
different handling of the Postal Header and additionally integrate functionality to
move css styles inline. Therefore we decided to write our own EmailParser
implementing IEmailParser Interface. Unfortunately with the internal on
the Email object we can't use the ImageEmbedder in our Parser. To ensure
extensibility of the EmailParser the ImageEmbedder should be made accessable.