Skip to content

Fix supply problems no data handling #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreuSignes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix supply problems no data handling #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions packages/cima_repository/lib/src/cima_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,22 +131,25 @@ class CimaRepository {
params: params,
);
log('statusCode: ${response.statusCode}');
if (response.statusCode != 200) {
return Left(ServerFailure());
}

try {
final cimaPaginado = CimaPaginado.fromJson(jsonDecode(response.body));
if (cimaPaginado.resultados?.isEmpty ?? true) {
return Right([]);
if (response.statusCode == 200) {
try {
final cimaPaginado =
CimaPaginado.fromJson(jsonDecode(response.body));
if (cimaPaginado.resultados?.isEmpty ?? true) {
return Right([]);
}
final problemasSuministro = cimaPaginado.resultados!
.map((e) => SupplyProblems.fromJson(e))
.toList();
return Right(problemasSuministro);
} catch (e) {
log('error: $e');
return Left(FormatFailure());
}
final problemasSuministro = cimaPaginado.resultados!
.map((e) => SupplyProblems.fromJson(e))
.toList();
return Right(problemasSuministro);
} catch (e) {
log('error: $e');
return Left(FormatFailure());
} else if (response.statusCode == 204) {
return Left(NoDataFailure());
} else {
return Left(ServerFailure());
}
} catch (e) {
return Left(ServerFailure());
Expand Down
9 changes: 9 additions & 0 deletions packages/cima_repository/test/src/cima_repository_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,15 @@ void main() {
expect(result.fold((_) => null, (r) => r), problemasSuministro);
});

test('find problemas suministro without data', () async {
when(() => apiClient.getProblemasSuministro(params: {}))
.thenAnswer((_) async => Response('', 204));

final repository = CimaRepository(remoteDataSource: apiClient);
final result = await repository.findProblemasSuministro(params: {});
expect(result, Left(NoDataFailure()));
});

test('find with params', () async {
final params = {'nombre': 'aspirina'};
final problemasSuministroRaw =
Expand Down
Loading