Skip to content

Add Config File #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andreiverse wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add Config File #8

andreiverse wants to merge 11 commits into from

Conversation

@andreiverse
Copy link
Owner

@andreiverse andreiverse commented May 10, 2021

as requested in #7

andreiverse
andreiverse commented May 10, 2021
View reviewed changes
daanbreur added 2 commits May 11, 2021 10:37
@daanbreur
Configuration File Structure
ae50ef4 
It contains:
- VersionNumber (string)
- DefaultWordlist (id, int)
- Wordlists (Wordlist sequence, custom type needs import)
@daanbreur
Create the VafWordlist Type.
3c6ea49 
For now it only has a Path and an ID.
@daanbreur daanbreur mentioned this pull request May 11, 2021
Merged
andreiverse and others added 6 commits May 11, 2021 12:51
@andreiverse
Merge pull request #9 from daanbreur/vaf-configfile-base
973cebf 
Vaf configfile base
@andreiverse
add readVafConfig
47e9ca9
@daanbreur
Removed the version number from the configfile.
5996e65
@andreiverse
Merge pull request #10 from daanbreur/vaf-configfile-base
794eefc 
Removed the version number from the configfile.
@daanbreur
Create import function
cfe365b 
Return Type *VafConfigStructure*
@daanbreur
Create parseVafConfig file.
dc991bc 
Contains *parseWordlist* and *parseVafConfig* function

parseWordlist <private>:
 - parameter type *JsonNode*
 - returns type *VafWordlist*

 parseVafConfig <public>:
 - parameter type *JsonNode*
 - returns type *VafConfigStructure*
@daanbreur daanbreur mentioned this pull request May 14, 2021
Merged
@andreiverse
Copy link
Owner Author

andreiverse commented May 15, 2021 •
edited
Loading

We should make it so users don't need to provide the ID in the config file and only the path, like this:

{
 "wordlists": ["/wordlist1", "/wordlist2"]
}

@daanbreur
Copy link
Collaborator

daanbreur commented May 16, 2021

Yes sir! Im working on it.
How do you select the default tho? just using a path?
If so the data would be:

{
  "DefaultWordlist": "/usr/wordlists/wordlist1.txt",
  "Wordlists": [ "/usr/wordlists/wordlist1.txt", "/usr/wordlists/wordlist2.txt", "/usr/wordlists/wordlist3.txt"]
}

@andreiverse
Copy link
Owner Author

andreiverse commented May 16, 2021

Yes sir! Im working on it.
How do you select the default tho? just using a path?
If so the data would be:

{
  "DefaultWordlist": "/usr/wordlists/wordlist1.txt",
  "Wordlists": [ "/usr/wordlists/wordlist1.txt", "/usr/wordlists/wordlist2.txt", "/usr/wordlists/wordlist3.txt"]
}

If there's only one element in the array, use that by default, otherwise ask for the number like 1-10

@daanbreur
Copy link
Collaborator

daanbreur commented May 16, 2021

Guess we could do that. More like a number from 0 - length

@andreiverse
Copy link
Owner Author

andreiverse commented May 18, 2021

Guess we could do that. More like a number from 0 - length

Yup

@andreiverse andreiverse added enhancement New feature or request lowpriority labels Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daanbreur daanbreur daanbreur left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request lowpriority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreiverse @daanbreur