Adds support to more column types #95
Conversation
traduzindo p ptbr; capitalizando tdas as palavras do titulo da issue; add opção de criterios extras
andre-filho
left a comment
andre-filho
left a comment
There was a problem hiding this comment.
Thnx for the contrib, but some changes are needed. Btw, you must follow the commit rules and language to avoid having your commits squashed.
| """ | ||
| Adds the header and a final new line to the issue description string. | ||
| """ | ||
| return str('**Issue description:**\n---\n\n' + string + '\n'*2) |
There was a problem hiding this comment.
Keep it in english for now. Translations will be added later. Btw there is a branch named desenho-br I think, that writes the issue titles and stuff in pt-br and is deployed on ezissue-br lib
| subid = subid.upper() | ||
| prefix = prefix.upper() | ||
| title = title.capitalize() | ||
| title = ' '.join([t.capitalize() for t in title.split(' ')]) |
There was a problem hiding this comment.
Split this into a function plz
| """ | ||
| checkboxes = add_md_checkbox(string) | ||
| acc_criteria_title = "**Acceptance criteria:**\n---\n\n" | ||
| checkboxes = add_md_checkbox(string) if string != 'Não há critérios.\n' else string |
There was a problem hiding this comment.
Shouldn't this logic be inside the add_md_checkbox function? It is simple, yes, but inside the function would be better organized
| Formats the string adding the acceptance criteria header and adds a final | ||
| new line. | ||
| """ | ||
| checkboxes = add_md_checkbox(string) if string != 'Não há critérios.\n' else string |
|
|
||
|
|
||
| def create_issue_json(configuration_row, values_row, repo_host): | ||
| def create_issue_json(configuration_row, values_row, repo_host, blk): |
There was a problem hiding this comment.
What is blk? Use significant variable names
| row[0], idx+1, prefix, subid, numerate) | ||
|
|
||
| rows = make_md_formatting(columns, rows) | ||
| columns = [x.strip() for x in columns] |
There was a problem hiding this comment.
Significant variable names, plz
| for row in rows: | ||
| response, issue = make_api_call( | ||
| create_issue_json(columns, row, repo_host), | ||
| create_issue_json(columns, row, repo_host, blacklist), |
There was a problem hiding this comment.
If blacklist is being used on various places, should be extracted to constant
andre-filho
changed the title
2 participants
No description provided.