Open
Conversation
|
Code Climate has analyzed commit 2ace848 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 90.4% (90% is the threshold). This pull request will bring the total coverage in the repository to 95.7% (0.0% change). View more on Code Climate. |
Mcdavid95
force-pushed
the
ft-get-employee-list-168427812
branch
from
df8d650 to
8fde7a2
Compare
Mcdavid95
force-pushed
the
ft-get-employee-list-168427812
branch
from
8fde7a2 to
2c74359
Compare
Contributor
|
what is the status of this PR? |
Mcdavid95
force-pushed
the
ft-get-employee-list-168427812
branch
from
2c74359 to
ef8fa25
Compare
Mcdavid95
force-pushed
the
ft-get-employee-list-168427812
branch
from
ef8fa25 to
37db93b
Compare
Mcdavid95
force-pushed
the
ft-get-employee-list-168427812
branch
from
37db93b to
3f554cb
Compare
- create controller to get employees - only accessible by manager and super admin [Finishes (#168427812)]
Mcdavid95
force-pushed
the
ft-get-employee-list-168427812
branch
from
3f554cb to
2ace848
Compare
Collaborator
Author
Sorry had some issues with power and the coverage too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR do?
Description
create controller to get employees
only accessible by manager and super admin
How can this be manually tested?
npm installcreatedb {database_name}.envfile and add database url under the keyDATABASE_URL_TESTnpm run seed/api/v1/employees/api/v1/docsto test further with swagger uiRelevant Pivotal tracker stories