Conversation
| } | ||
|
|
||
| .article-like-icons { | ||
| transition: all .2s ease; |
There was a problem hiding this comment.
.2 should be written with a leading zero as 0.2
| } | ||
| } | ||
|
|
||
| .article-like-icons { |
There was a problem hiding this comment.
Merge rule .article-like-icons with rule on line 99
| font-size: 2rem; | ||
|
|
||
| .featured-card { | ||
| transition: .2s ease; |
There was a problem hiding this comment.
Properties should be ordered backface-visibility, transition.2 should be written with a leading zero as 0.2
| margin-top: 1rem; | ||
| } | ||
|
|
||
| .ReactTags__remove { |
There was a problem hiding this comment.
Selector ReactTags__remove should be written in lowercase with hyphens
| padding: 0.6rem 1rem; | ||
| outline: none; | ||
| border: none; | ||
| border: 1px solid #ced4da; |
There was a problem hiding this comment.
Color literals like #ced4da should only be used in variable declarations; they should be referred to via variable everywhere else.
Property border already defined on line 46
| width: 30em; | ||
| padding: 0.6rem 1rem; | ||
| outline: none; | ||
| border: none; |
There was a problem hiding this comment.
border: 0 is preferred over border: none
| margin: 0.1em; | ||
| border-radius: 30px; | ||
| padding: 0.5rem; | ||
| margin-right:0.2rem; |
There was a problem hiding this comment.
Colon after property should be followed by one space
|
|
||
| .card-img-left { | ||
| width: 40%; | ||
| width: 100%; |
There was a problem hiding this comment.
Properties should be ordered object-fit, width
| } | ||
|
|
||
| .navbar { | ||
| border-bottom: solid 0.5px rgba(0,0,0,0.1); |
There was a problem hiding this comment.
Color literals like rgba(0, 0, 0, 0.1) should only be used in variable declarations; they should be referred to via variable everywhere else.
Commas in function arguments should be followed by one space
| <div className="article-list section" data-test="articleList"> | ||
| { articles && articles.slice(5).map((article) => { | ||
| <div className="article-list section card-columns" data-test="articleList"> | ||
| { articles && articles.slice(0,10).map((article) => { |
There was a problem hiding this comment.
A space is required after ',' comma-spacing
kirega
left a comment
kirega
left a comment
There was a problem hiding this comment.
The new home user interface it looking good, just as we had discussed.
4 participants
What does this PR do?
Improves the UI of the entire project
Description of the task to be completed
How should this be manually tested
npm installnpm starthttp://localhost:3000/