Open
Conversation
kirega
approved these changes
May 23, 2019
Contributor
kirega
left a comment
There was a problem hiding this comment.
Nice job refactoring the tests to help out with performance.
MainaKamau92
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes calls to the signup endpoint in all the tests
Description of the task to be completed
Create a user directly by invoking the user object creation method
How should this be manually tested?
virtualenv venvand activate itpip install -r dev-requirements.txtDATABASE_URLin a.envfile. Export the configuration variablepython manage.py testRelevant PT stories
https://www.pivotaltracker.com/story/show/166207237