Skip to content

#166207237 - Remove unnecessary signup calls#86

Open
kihuha wants to merge 1 commit intodevelopfrom
bg-remove-unnecessary-signup-166207237
Open

#166207237 - Remove unnecessary signup calls#86
kihuha wants to merge 1 commit intodevelopfrom
bg-remove-unnecessary-signup-166207237

Conversation

@kihuha
Copy link
Contributor

@kihuha kihuha commented May 23, 2019

What does this PR do?

Removes calls to the signup endpoint in all the tests

Description of the task to be completed

Create a user directly by invoking the user object creation method

How should this be manually tested?

  • Setup the following environmental variables in a .env file
DATABASE_URL=<database_url>
export DJANGO_SETTINGS_MODULE=authors.settings
export SECRET_KEY=<>
export FROM_EMAIL=<valid email>
export URL=<localhost>
export AH_HOST=<localhost>
export DOMAIN=<localhost>
  • Clone the repo and navigate to the root directory
  • Create a virtual environment by typing virtualenv venv and activate it
  • Install requirements by typing pip install -r dev-requirements.txt
  • Setup a database and define the DATABASE_URL in a .env file. Export the configuration variable
  • Run the tests by typing python manage.py test

Relevant PT stories

https://www.pivotaltracker.com/story/show/166207237

@kihuha kihuha temporarily deployed to ah-the-answer-backend-st-pr-86 May 23, 2019 10:10 Inactive
@kihuha kihuha requested review from ipaullly and kirega and removed request for ipaullly May 23, 2019 10:11
Copy link
Contributor

@kirega kirega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job refactoring the tests to help out with performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants