Skip to content
This repository was archived by the owner on Dec 11, 2024. It is now read-only.

feat(YouTube - Overlay Buttons): Add Set Brightness button#29

Draft
Francesco146 wants to merge 5 commits intoanddea:devfrom
Francesco146:set-brightness-button
Draft

feat(YouTube - Overlay Buttons): Add Set Brightness button#29
Francesco146 wants to merge 5 commits intoanddea:devfrom
Francesco146:set-brightness-button

Conversation

@Francesco146
Copy link
Collaborator

@Francesco146 Francesco146 commented Sep 6, 2024

@Francesco146
Copy link
Collaborator Author

Francesco146 commented Sep 22, 2024

todo:

  • understand how to add android.permission.WRITE_SETTINGS in the manifest
  • understand how can i restore control over the brightness when the video is closed
  • understand why previousBrightness is always -1.0 after the first initialization
  • tap and hold doesn't work
  • dynamic icon seems to not work in tap

@Francesco146
Copy link
Collaborator Author

Francesco146 commented Sep 22, 2024

now the implementation is almost done, it would be better to change the system brightness instead of the application brightness

edit:

understand how can i restore control over the brightness when the video is closed

this could be resolved by adding the android.permission.WRITE_SETTINGS permission

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant