Open
Conversation
RJWadley
force-pushed
the
check-partial-support
branch
from
cc1dfdd to
38a8a63
Compare
RJWadley
force-pushed
the
check-partial-support
branch
2 times, most recently
from
17975bb to
f6eec04
Compare
RJWadley
force-pushed
the
check-partial-support
branch
from
f6eec04 to
5a3ab9a
Compare
Collaborator
|
I added this to a 6.1 milestone, since I would like to get 6.0 out as fast as possible. I would like to use some benchmarks to see the performance costs before adding in MDN. |
This was referenced Jul 5, 2023
|
Any update/what's pending for this to get merged? |
|
Hello! Is there any christmas miracle for this PR 🥲 |
|
@clshortfuse @shish @edg2s @thoughtspile please, any comment |
Contributor
My comment is "I don't know why I'm being tagged in this issue", hope that helps ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves checking for partially supported properties by using MDN to check if the specific value we're using is unsupported or not.
For example,
appearance: autogot support in chrome 83, so it would warn withchrome 81but not withchrome 83. Meanwhile,appearance: nonegained support much earlier, so it wouldn't warn with either 83 or 81.As of right now it only checks declaration value pairs. the behavior is unchanged for other types of css features
details
MDN isn't part of feature detection, which remains unchanged. This is focused on providing better messages to the end user instead. Whenever partial support is detected, we then get more information from MDN to determine if we need to report the issue at all, and report with a more specific message if needed.
One thing to consider is that MDN adds a lot of weight (something like 10MB). This isn't a big issue for most environments, but it may matter for some. For example, if someone wanted to use this in the browser (why would they?) it would be much too large. If we think this is a problem we could gate this behind an option and import the data dynamically.
Closes
fixes #70
fixes #71
fixes #106
fixes #146