Dummy pass by anamaoh · Pull Request #1 · anamaoh/llvm-project

anamaoh · 2025-10-29T09:47:33Z

No description provided.

vvuksanovic · 2025-10-29T11:01:04Z

.gitignore


 # Nested build directory
-/build*
+/build*  


Please revert unnecessary whitespace changes.

vvuksanovic · 2025-10-29T11:01:15Z

foo_00.ll

Is this file used for something?

vvuksanovic · 2025-10-29T11:01:30Z

llvm/include/llvm/Transforms/Utils/DebugRecordCounter.h

+
+namespace llvm {
+
+    class DebugRecordCounterPass : public PassInfoMixin<DebugRecordCounterPass> {


Please format all added code using git-clang-format.

vvuksanovic · 2025-10-29T11:01:38Z

llvm/lib/CMakeLists.txt

 endif()

-# Component post-processing
+# Component post-processing  


Unnecessary extra whitespace.

vvuksanovic · 2025-10-29T11:01:44Z

llvm/lib/Passes/PassBuilderPipelines.cpp

 #include "llvm/Transforms/Vectorize/SLPVectorizer.h"
 #include "llvm/Transforms/Vectorize/VectorCombine.h"

+#include "llvm/Transforms/Utils/DebugRecordDeleter.h"


This include can be grouped with the previous ones.

vvuksanovic · 2025-10-29T11:01:50Z

llvm/lib/Passes/PassBuilderPipelines.cpp


  if (isLTOPreLink(Phase))
-    addRequiredLTOPreLinkPasses(MPM);
+    addRequiredLTOPreLinkPasses(MPM); 


Extra whitespace.

vvuksanovic · 2025-10-29T11:02:00Z

llvm/lib/Transforms/Utils/DebugRecordCounter.cpp

+// build/bin/opt -disable-output /home/ana-marija/Documents/foo_00.ll -passes=dbg-counter
+PreservedAnalyses DebugRecordCounterPass::run(Module &M, ModuleAnalysisManager &AM) {
+
+    int dbg_values, dbg_declares, dbg_assigns;


This can be declared as unsigned

vvuksanovic · 2025-10-29T11:02:25Z

llvm/lib/Transforms/Utils/DebugRecordCounter.cpp

+    int dbg_values, dbg_declares, dbg_assigns;
+
+    for (Function &F : M) { 
+        errs() << "Function: " << F.getName() << "\n"; 


Investigate the LLVM_DEBUG macro to print output only when specified by the -debug-only=[name] option.

vvuksanovic · 2025-10-29T11:02:35Z

llvm/lib/Transforms/Utils/DebugRecordDeleter.cpp

+
+    return PreservedAnalyses::all();
+
+}


There is a missing newline at the end of this and some other files.

vvuksanovic · 2025-10-30T11:04:38Z

llvm/lib/Transforms/Utils/DebugRecordDeleter.cpp

+PreservedAnalyses DebugRecordDeleterPass::run(Module &M,
+                                              ModuleAnalysisManager &AM) {
+
+  bool modified = StripDebugInfo(M);


This will remove all debug information, not just the debug record instructions. Also, modified is unused.

vvuksanovic · 2025-10-30T11:05:08Z

llvm/test/Transforms/Util/dbgi-counter-1.ll

+!33 = !DILocation(line: 13, column: 6, scope: !31)
+!34 = !DILocation(line: 13, column: 10, scope: !31)
+!35 = !DILocation(line: 14, column: 9, scope: !31)
+!36 = !DILocation(line: 14, column: 2, scope: !31)


There are missing newlines at the end of test files.

jdmitrovic-syrmia · 2025-10-30T11:16:37Z

llvm/test/Transforms/Util/dbgi-counter-2.ll

+!0 = !DIGlobalVariableExpression(var: !1, expr: !DIExpression())
+!1 = distinct !DIGlobalVariable(name: "s", scope: !2, file: !5, line: 8, type: !6, isLocal: false, isDefinition: true)
+!2 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !3, producer: "clang version 22.0.0git (https://github.com/anamaoh/llvm-project.git 782a91e1fc94d9c82495f60afc5ed5edd72de776)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, globals: !4, splitDebugInlining: false, nameTableKind: None)
+!3 = !DIFile(filename: "/home/ana-marija/Documents/load.cpp", directory: "/home/ana-marija/Desktop/LLVM/llvm-project", checksumkind: CSK_MD5, checksum: "1bce1e274606359bd3ee799e44db5ab7")


Please use dummy paths throughout tests. Consult DebugInfo tests for reference.

jdmitrovic-syrmia · 2025-10-30T11:26:38Z

llvm/lib/Transforms/Utils/DebugRecordCounter.cpp

+#define DEBUG_TYPE "counter"
+#include "llvm/Support/Debug.h"


DEBUG_TYPE should be defined after all includes.

vvuksanovic suggested changes Oct 29, 2025

View reviewed changes

anamaoh force-pushed the dummy-pass branch from d42e0d1 to 8929384 Compare October 29, 2025 14:44

anamaoh requested a review from vvuksanovic October 29, 2025 14:48

anamaoh force-pushed the dummy-pass branch from 8929384 to f94f1b5 Compare October 30, 2025 10:55

vvuksanovic suggested changes Oct 30, 2025

View reviewed changes

anamaoh force-pushed the dummy-pass branch from f94f1b5 to ce69b54 Compare October 30, 2025 11:39

anamaoh requested a review from vvuksanovic October 30, 2025 11:39

vvuksanovic approved these changes Oct 30, 2025

View reviewed changes

jdmitrovic-syrmia suggested changes Oct 30, 2025

View reviewed changes

anamaoh added 3 commits October 30, 2025 13:26

Added counter and deleter passes for debug info

8bdf679

Added tests for new passes (dbg-counter & dbg-deleter)

46ca431

Included the DebugRecordDeleter pass into the -O2 pipeline.

61e3dff

anamaoh force-pushed the dummy-pass branch from ce69b54 to 61e3dff Compare October 30, 2025 13:55

anamaoh requested a review from jdmitrovic-syrmia October 30, 2025 13:55

jdmitrovic-syrmia approved these changes Oct 30, 2025

View reviewed changes


		namespace llvm {

		class DebugRecordCounterPass : public PassInfoMixin<DebugRecordCounterPass> {

Comments

Conversation

anamaoh commented Oct 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants