upgrade delta constraint and fix ty

[geoHeil]

resolves: #582

[geoHeil]

• upgrade delta constraint and fix ty #583 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage Report (Python 3.13) •

File	Stmts	Miss	Cover	Missing
ext/dagster
metaxify.py	165	10	93%	410, 449–450, 479, 492, 494, 496, 502, 504, 507
ext/sqlmodel
plugin.py	137	33	75%	115–117, 192–193, 197, 199, 201–203, 205, 207, 210, 213, 215–216, 219–220, 223–225, 228, 232, 472, 479, 482–483, 501, 506, 512, 522, 524–525
metadata_store
base.py	470	145	69%	3, 5–9, 11–15, 17–19, 25–27, 32, 36, 48–50, 55–57, 64, 67, 86, 88, 93, 98, 104, 109, 120, 148, 155, 158, 160, 230–231, 244–245, 258, 379, 440, 463, 549, 651, 700, 729, 731–732, 787, 864, 947–948, 991–992, 995–996, 1013, 1043–1044, 1049–1050, 1071, 1076, 1088, 1093, 1125, 1142, 1160, 1171, 1185, 1209, 1223, 1227, 1240, 1250–1251, 1275, 1302, 1337, 1371, 1428, 1495, 1511, 1518, 1526, 1532, 1536, 1556, 1603, 1632, 1657, 1691, 1717, 1730, 1732, 1789, 1868, 1870, 1873–1874, 1877–1878, 1882, 1892, 1905, 1907, 1909–1911, 1916–1917, 1920–1921, 1923–1925, 1927, 1930–1931, 1934–1937, 1940, 1949–1950, 1952–1953, 1956, 1959, 1961–1963, 1967–1968, 1971–1973, 1976, 1978, 1982
TOTAL	8596	3395	60%

Tests	Skipped	Failures	Errors	Time
1964	22 💤	0 ❌	0 🔥	6m 33s ⏱️

[github-actions]

Test Results (Python 3.10)

1 964 tests   1 942 ✅  6m 26s ⏱️
    1 suites     22 💤
    1 files        0 ❌

Results for commit 1439f72.

♻️ This comment has been updated with latest results.

[github-actions]

Coverage Report (Python 3.10) •

File	Stmts	Miss	Cover	Missing
ext/dagster
metaxify.py	165	10	93%	410, 449–450, 479, 492, 494, 496, 502, 504, 507
ext/sqlmodel
plugin.py	137	33	75%	115–117, 192–193, 197, 199, 201–203, 205, 207, 210, 213, 215–216, 219–220, 223–225, 228, 232, 472, 479, 482–483, 501, 506, 512, 522, 524–525
metadata_store
base.py	470	145	69%	3, 5–9, 11–15, 17–19, 25–27, 32, 36, 48–50, 55–57, 64, 67, 86, 88, 93, 98, 104, 109, 120, 148, 155, 158, 160, 230–231, 244–245, 258, 379, 440, 463, 549, 651, 700, 729, 731–732, 787, 864, 947–948, 991–992, 995–996, 1013, 1043–1044, 1049–1050, 1071, 1076, 1088, 1093, 1125, 1142, 1160, 1171, 1185, 1209, 1223, 1227, 1240, 1250–1251, 1275, 1302, 1337, 1371, 1428, 1495, 1511, 1518, 1526, 1532, 1536, 1556, 1603, 1632, 1657, 1691, 1717, 1730, 1732, 1789, 1868, 1870, 1873–1874, 1877–1878, 1882, 1892, 1905, 1907, 1909–1911, 1916–1917, 1920–1921, 1923–1925, 1927, 1930–1931, 1934–1937, 1940, 1949–1950, 1952–1953, 1956, 1959, 1961–1963, 1967–1968, 1971–1973, 1976, 1978, 1982
TOTAL	8596	3395	60%

Tests	Skipped	Failures	Errors	Time
1964	22 💤	0 ❌	0 🔥	6m 26s ⏱️

[github-actions]

Coverage Report (Python 3.11) •

File	Stmts	Miss	Cover	Missing
ext/dagster
metaxify.py	165	10	93%	410, 449–450, 479, 492, 494, 496, 502, 504, 507
ext/sqlmodel
plugin.py	137	33	75%	115–117, 192–193, 197, 199, 201–203, 205, 207, 210, 213, 215–216, 219–220, 223–225, 228, 232, 472, 479, 482–483, 501, 506, 512, 522, 524–525
metadata_store
base.py	470	145	69%	3, 5–9, 11–15, 17–19, 25–27, 32, 36, 48–50, 55–57, 64, 67, 86, 88, 93, 98, 104, 109, 120, 148, 155, 158, 160, 230–231, 244–245, 258, 379, 440, 463, 549, 651, 700, 729, 731–732, 787, 864, 947–948, 991–992, 995–996, 1013, 1043–1044, 1049–1050, 1071, 1076, 1088, 1093, 1125, 1142, 1160, 1171, 1185, 1209, 1223, 1227, 1240, 1250–1251, 1275, 1302, 1337, 1371, 1428, 1495, 1511, 1518, 1526, 1532, 1536, 1556, 1603, 1632, 1657, 1691, 1717, 1730, 1732, 1789, 1868, 1870, 1873–1874, 1877–1878, 1882, 1892, 1905, 1907, 1909–1911, 1916–1917, 1920–1921, 1923–1925, 1927, 1930–1931, 1934–1937, 1940, 1949–1950, 1952–1953, 1956, 1959, 1961–1963, 1967–1968, 1971–1973, 1976, 1978, 1982
TOTAL	8596	3395	60%

Tests	Skipped	Failures	Errors	Time
1964	22 💤	0 ❌	0 🔥	7m 6s ⏱️

[github-actions]

Coverage Report (Python 3.12) •

File	Stmts	Miss	Cover	Missing
ext/dagster
metaxify.py	165	10	93%	410, 449–450, 479, 492, 494, 496, 502, 504, 507
ext/sqlmodel
plugin.py	137	33	75%	115–117, 192–193, 197, 199, 201–203, 205, 207, 210, 213, 215–216, 219–220, 223–225, 228, 232, 472, 479, 482–483, 501, 506, 512, 522, 524–525
metadata_store
base.py	470	145	69%	3, 5–9, 11–15, 17–19, 25–27, 32, 36, 48–50, 55–57, 64, 67, 86, 88, 93, 98, 104, 109, 120, 148, 155, 158, 160, 230–231, 244–245, 258, 379, 440, 463, 549, 651, 700, 729, 731–732, 787, 864, 947–948, 991–992, 995–996, 1013, 1043–1044, 1049–1050, 1071, 1076, 1088, 1093, 1125, 1142, 1160, 1171, 1185, 1209, 1223, 1227, 1240, 1250–1251, 1275, 1302, 1337, 1371, 1428, 1495, 1511, 1518, 1526, 1532, 1536, 1556, 1603, 1632, 1657, 1691, 1717, 1730, 1732, 1789, 1868, 1870, 1873–1874, 1877–1878, 1882, 1892, 1905, 1907, 1909–1911, 1916–1917, 1920–1921, 1923–1925, 1927, 1930–1931, 1934–1937, 1940, 1949–1950, 1952–1953, 1956, 1959, 1961–1963, 1967–1968, 1971–1973, 1976, 1978, 1982
TOTAL	8596	3395	60%

Tests	Skipped	Failures	Errors	Time
1964	22 💤	0 ❌	0 🔥	7m 2s ⏱️

[danielgafni]

Couple you explain the Dagster changes? They aren’t related to the title of this PR

[geoHeil]

yes they are related to TY; I did run the uv sync --all-extras --all-groups --upgrade after upgrading the delta dependency - so ty was also upgraded and now seems to be a bit different/more stringent

[danielgafni]

I mean, there are some non-trivial changes to code that has been working for me, with comments like "AssetDep is not hashable" - but I don't think this is true since the code has been working before? What issue is the new code addressing? I'll be able to look into it on Monday, but for now won't it be easier to remove these changes from this PR to make it obviously right?

[geoHeil]

I think we do not have to rush this one; should we split it into 2x perhaps 1) for the new version of delta and 2) one for the uv upgrade which incluees and upgrade for ty? (and the hotfixes)

[danielgafni]

Honestly, I'm not sure we should enforce the >1.3.0 deltalake pin in our requirements.

The deltalake issue has only affected our testing environment (moto S3 server specifically), the current constraint works perfectly fine with Metaxy.

We shouldn't force this upgrade on our users since Metaxy itself doesn't require it at runtime.

I've added more details in the original issue.

---

The ty thing is ok to fix. Upgrading it would be nice as well. But how are these Dagster integration changes related to ty?

[geoHeil]

ok - let me close here and run the ty upgrade solo #584