Skip to content

Add Windows Installer using WiX Toolset #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
an-dr merged 20 commits into from
Jan 21, 2025
Merged

Add Windows Installer using WiX Toolset #5

an-dr merged 20 commits into from
Jan 21, 2025

Conversation

@Arteiii
Copy link
Contributor

@Arteiii Arteiii commented Jan 13, 2025 •
edited by an-dr
Loading

  • added cargo-wix.yml for windows installer files and integrated into build.yml
  • build.yml no longer runs on pr instead rust-check.yml workflow runs (Formatting, Clippy, Linters, and Tests)
  • fixed formatting

an-dr
an-dr requested changes Jan 14, 2025
View reviewed changes
Copy link
Owner

@an-dr an-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that addition! Could not do it myself. There are several minor things that I would like to have and les't merge it!

Note, that it does not cover #1 fully as it is not that modern msix installer but msi. At the same time, msi has better compatibility and some might prefer it just because of familiarity. So I would like to have them both 😉

@Arteiii
Copy link
Contributor Author

Arteiii commented Jan 14, 2025

sure I'll edit it ASAP 🙏

@an-dr
Copy link
Owner

an-dr commented Jan 20, 2025

Hi @Arteiii, how it is going? I made a big merge recently, it caused a minor conflict. Let me know if you are still interested in delivery of these changes or need anything to finalize the PR, tnx.

@Arteiii
Copy link
Contributor Author

Arteiii commented Jan 20, 2025

I can check tomorrow hopefully

sorry been busy lately 🙏

@Arteiii
Copy link
Contributor Author

Arteiii commented Jan 20, 2025

I resolved some comments lmk if that's fine

will push the changes

@an-dr an-dr changed the title Fixes #1 Add Windows Installer using WiX Toolset Jan 21, 2025
@an-dr an-dr merged commit 01eb5ce into an-dr:main Jan 21, 2025
3 of 4 checks passed
@an-dr
Copy link
Owner

an-dr commented Jan 21, 2025

@Arteiii Merged! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@an-dr an-dr an-dr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Arteiii @an-dr