Improve favicon logic #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use Google favicon service as primary source (faster, more reliable) - Add cache support: skip re-fetching existing favicons - Add --force flag to bypass cache when needed - Store failed lookups as null in manifest to avoid retrying - Reduce timeout from 10s to 8s - Simplify fetch strategy (fewer HTTP requests per site) - Change output extension to .ico to match actual content
Contributor
|
Is there a reason to use the api over the direct one? |
Contributor
Author
|
yes, It seems to be able to fetch the favicons for the 4 missing websites. Specifically: Ajay, Archishman, Chirayu and Noel |
Contributor
Author
|
removed caching, and also fetches .svg .png favicons if found also maybe we should open an Issue to rework the favicon fetching logic with bun's HTMLRewriter logic for future reference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
P.S use --force to refresh cache