Open
Conversation
…eature/add-more-interfaces
Feature/add more interfaces
Author
|
@amq92 Ruff formatting works on my machine. For the updated return behavior: instead of changing it immediately, could add an environment flag ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
scontrolandsacctinterfaces, and updates the return logic ofsbatch.Changes
SlurmSacctWrapper: Parses resource info fromsacct. Added as a variable toSlurm.SlurmScontrolWrapper: Parses resource info fromscontrol. Also added as a variable toSlurm.returnlogic forsbatch:self) instead of just thejob_id. This allows access to the job’s namespace and integrates smoothly withsacctandscontrol.int(slurm)now returns thejob_id, which integrates nicely withscancel.README.mdwith examples and docs.ruffconform codeAll tests are passing. The only exception is srun, which isn’t supported on our cluster. Would appreciate 2nd set of eyes on this.
Example usage