-
Notifications
You must be signed in to change notification settings - Fork 4
Feat/cor 32 requests made through client never error #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LukeT-Amplience
wants to merge
9
commits into
amplience:master
Choose a base branch
from
LukeT-Amplience:feat/COR-32-Requests-made-through-client-never-error
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d00ddb9
feat: add fetch method to client
LukeT-Amplience dcc100a
feat: refactor fetch method in HttpClient
LukeT-Amplience 6bace8b
feat: stringify non string data in HttpClient
LukeT-Amplience bebeaf5
feat: add HttpError to client
LukeT-Amplience 3197f54
feat: remove response data from error
LukeT-Amplience 01cdf0f
feat: fix typo
LukeT-Amplience 83d21c0
feat: fix typo
LukeT-Amplience 603146e
feat: fix typo
LukeT-Amplience b3ba60b
feat: remove type check on response
LukeT-Amplience File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import { HttpRequest, HttpResponse } from './HttpClient'; | ||
|
|
||
| export class HttpError extends Error { | ||
| constructor( | ||
| message: string, | ||
| public readonly request?: HttpRequest, | ||
| public readonly response?: HttpResponse | ||
| ) { | ||
| super(message); | ||
| Object.setPrototypeOf(this, new.target.prototype); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, would be good to get some basic docs down as well.
also DEFAULT_ERROR shows the shape of errors we normally return from API errors. unsure if we need to follow that shape here but looks good!