Fix measurements for Lightsaber benchmark#21
Open
wzhao18 wants to merge 11 commits intoampersand-projects:masterfrom
Open
Fix measurements for Lightsaber benchmark#21wzhao18 wants to merge 11 commits intoampersand-projects:masterfrom
wzhao18 wants to merge 11 commits intoampersand-projects:masterfrom
Conversation
added 2 commits
June 5, 2022 22:26
Collaborator
Author
|
Making this a draft for now, want to look at whether it's possible for the main thread to wait for the work threads to finish. |
added 5 commits
June 6, 2022 21:23
8168563 to
9b0484d
Compare
9b0484d to
ca254e7
Compare
anandj91
requested changes
Oct 15, 2022
lightsaber_bench/run.sh
Outdated
Comment on lines
17
to
24
Contributor
There was a problem hiding this comment.
This looks like code copied from C++. Why is this part of a bash script?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially turn on the performance monitor built-in in lightsaber application and repeatedly run the benchmark.
Default benchmark parameters are changed to size 40000000 and runs 100 times. Some sizes will cause the program seg fault, such as 10000000.
Result now looks like:
If turn on remote sink: