Right align numeric columns #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates table display functionality to right align numeric columns in various UI components.
- Added column alignment parameters in the TUI and command output modules.
- Updated table formatter functions to accept and apply custom column alignments for numeric columns.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| chuck_data/ui/tui.py | Introduces column_alignments for numeric columns in the table display. |
| chuck_data/ui/table_formatter.py | Adds support for the column_alignments parameter and integrates alignment handling in header addition. |
| chuck_data/command_output.py | Implements column_alignments for displaying numeric columns in command outputs. |
Comments suppressed due to low confidence (1)
chuck_data/ui/table_formatter.py:105
- The block of code handling header alignment is duplicated (once around lines 70-80 and again around lines 105-113). Consider refactoring this logic into a helper function to improve maintainability.
table.add_column(header, style=header_style, justify=cast(Any, alignment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.