Skip to content

Conversation

@john-b-rush
Copy link
Contributor

Improves the ux for using the various commands with and without the agent

@john-b-rush john-b-rush requested a review from Copilot June 6, 2025 18:54
@john-b-rush john-b-rush merged commit 010a59e into main Jun 6, 2025
2 checks passed
@john-b-rush john-b-rush deleted the improve-command-ux branch June 6, 2025 18:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances user and agent experiences by introducing a display toggle for listing commands, adding fuzzy matching to selection commands, updating tests, refining UI output, and improving agent guidance.

  • Introduced display parameter and changed agent_display to conditional for list-catalogs, list-schemas, and list-tables; tests updated accordingly.
  • Renamed and upgraded selection commands to select-catalog and select-schema with fuzzy matching, step callbacks, and updated handler definitions.
  • Expanded UI tables with an Owner column, refined condensed tool output, and revised the agent system prompt workflows.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_agent_tool_display_routing.py Adjusted tests to expect conditional vs full displays
tests/commands/* Updated tests to use schema/catalog params and check display behavior
src/commands/list_*.py Added display flag, conditional agent_display, and updated parameters
src/commands/*selection.py Implemented fuzzy matching and renamed to select-schema/select-catalog
src/ui/tui.py Refined condensed output logic and added Owner column
src/command_output.py Updated catalog display to include owner and styling functions
src/agent/prompts/default_system_prompt.py Revised agent workflow guidance for catalog/schema/table commands
Comments suppressed due to low confidence (4)

src/agent/prompts/default_system_prompt.py:21

  • The prompt uses select_catalog (underscore) but the command is named select-catalog (dash). Update to the correct command name and ensure consistent naming.
-   - If user asks to "use X catalog" or "switch to X catalog": DIRECTLY use select_catalog with catalog parameter (accepts name, has built-in fuzzy matching). DO NOT call list_catalogs first - select_catalog has built-in fuzzy matching and will find the catalog.

src/agent/prompts/default_system_prompt.py:28

  • [nitpick] The workflow numbering is inconsistent (1, 3, 4, 5, 6). Consider fixing the numbering to maintain a clear sequence.
3. STITCH INTEGRATION: To set up identity graph or customer 360 with Stitch:

src/agent/prompts/default_system_prompt.py:42

  • This line incorrectly references select_catalog and finding a catalog when discussing warehouses. It should refer to select-warehouse and finding a warehouse.
-   - If user asks to "use X warehouse" or "switch to X warehouse": use select_warehouse with warehouse parameter (accepts ID or name, has built-in fuzzy matching). DO NOT call list_warehouses first - select_catalog has built-in fuzzy matching and will find the catalog.

src/ui/tui.py:767

  • [nitpick] New Owner column was added to the catalog display. Consider adding or extending UI tests to verify the Owner column is rendered correctly.
            columns=["name", "type", "comment", "owner"],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants