Skip to content

Conversation

@ampersand-ops
Copy link
Collaborator

This updates the dependency to version 11c129ad34f1590f1547c3b8e595f9d7a907e0d2 from main

@ampersand-ops ampersand-ops added the openapi The PR updates OpenAPI definitions label Dec 22, 2025
Comment on lines +72 to +79
export function instanceOfPatchObjectConfigContentRequest(value: object): boolean {
let isInstance = true;
isInstance = isInstance && "groupRef" in value;
isInstance = isInstance && "action" in value;
isInstance = isInstance && "changes" in value;
isInstance = isInstance && "installationId" in value;

return isInstance;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation logic requires both groupRef AND installationId to be present, but the documentation (lines 31-32, 49-50) states "Either groupRef or installationId must be provided". This creates a logic error where the validation will fail for legitimate API calls that only provide one identifier.

The validation should be:

export function instanceOfPatchObjectConfigContentRequest(value: object): boolean {
    let isInstance = true;
    isInstance = isInstance && "action" in value;
    isInstance = isInstance && "changes" in value;
    isInstance = isInstance && ("groupRef" in value || "installationId" in value);
    return isInstance;
}
Suggested change
export function instanceOfPatchObjectConfigContentRequest(value: object): boolean {
let isInstance = true;
isInstance = isInstance && "groupRef" in value;
isInstance = isInstance && "action" in value;
isInstance = isInstance && "changes" in value;
isInstance = isInstance && "installationId" in value;
return isInstance;
export function instanceOfPatchObjectConfigContentRequest(value: object): boolean {
let isInstance = true;
isInstance = isInstance && "action" in value;
isInstance = isInstance && "changes" in value;
isInstance = isInstance && ("groupRef" in value || "installationId" in value);
return isInstance;
}

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openapi The PR updates OpenAPI definitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants