Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,10 @@ import { useConnectionsListQuery } from "src/hooks/query/useConnectionsListQuery
import { AMP_SERVER } from "src/services/api";

import { NoWorkspaceEntryContent } from "../NoWorkspaceEntry/NoWorkspaceEntryContent";
import { SalesforceSubdomainEntry } from "../WorkspaceEntry/Salesforce/SalesforceSubdomainEntry";
import { WorkspaceEntryContent } from "../WorkspaceEntry/WorkspaceEntryContent";

const DEFAULT_WIDTH = 600; // px
const DEFAULT_HEIGHT = 600; // px
const PROVIDER_SALESFORCE = "salesforce";

/** Payload shape we expect from the popup */
type AuthEvent =
Expand Down Expand Up @@ -68,7 +66,6 @@ export function OauthFlow2({
const [error, setError] = useState<string | null>(moduleError || null);

// workspace and metadata states
const [workspace, setWorkspace] = useState<string>("");
const [formData, setFormData] = useState<Record<string, string>>({});
const [metadata, setMetadata] = useState<ProviderMetadata>({});

Expand Down Expand Up @@ -106,16 +103,6 @@ export function OauthFlow2({
return () => window.removeEventListener("message", onMessage);
}, [queryClient]);

// Salesforce specific (separate case that can be refactored)
const setSalesforceWorkspace = (workspace: string) => {
setWorkspace(workspace);
setFormData((prev) => ({ ...prev, workspace: workspace }));
setMetadata((prev) => ({
...prev,
workspace: { value: workspace, source: "input" },
}));
};

const handleFormDataChange = (key: string, value: string) => {
setFormData((prev) => ({ ...prev, [key]: value }));
setMetadata((prev) => ({ ...prev, [key]: { value, source: "input" } }));
Expand Down Expand Up @@ -153,10 +140,7 @@ export function OauthFlow2({
projectId: projectId || "", // todo - update to use projectIdOrName
consumerName,
groupName,
providerWorkspaceRef:
provider === PROVIDER_SALESFORCE
? workspace
: metadata?.workspace?.value,
providerWorkspaceRef: metadata?.workspace?.value,
providerMetadata: metadata,
},
});
Expand All @@ -180,23 +164,6 @@ export function OauthFlow2({

// Determine which entry component to show based on provider and metadata
const entryComponent = (() => {
// Salesforce has a special entry component
if (provider === PROVIDER_SALESFORCE) {
return (
<SalesforceSubdomainEntry
handleSubmit={handleSubmit}
setWorkspace={setSalesforceWorkspace}
error={error}
isButtonDisabled={
workspace.length === 0 ||
isCreatingOauthConnection ||
isConnectionsFetching ||
!!error
}
/>
);
}

// If there are metadata fields, show the workspace entry form
if (metadataInputs.length > 0) {
return (
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,8 @@ import { useProviderInfoQuery } from "src/hooks/useProvider";
import { OAuthWindow } from "../OAuthWindow/OAuthWindow";
import { useOAuthPopupURL } from "../useOAuthPopupURL";

import { SalesforceSubdomainEntry } from "./Salesforce/SalesforceSubdomainEntry";
import { WorkspaceEntryContent } from "./WorkspaceEntryContent";

const PROVIDER_SALESFORCE = "salesforce";

interface WorkspaceOauthFlowProps {
provider: string;
consumerRef: string;
Expand All @@ -36,7 +33,6 @@ export function WorkspaceOauthFlow({
groupName,
providerName,
}: WorkspaceOauthFlowProps) {
const [workspace, setWorkspace] = useState<string>("");
const [formData, setFormData] = useState<Record<string, string>>({});
const [localError, setLocalError] = useState<string | null>(null);
// keeps track of whether the OAuth popup URL should be passed to the OAuthWindow
Expand All @@ -58,7 +54,7 @@ export function WorkspaceOauthFlow({
provider,
consumerName,
groupName,
provider === PROVIDER_SALESFORCE ? workspace : metadata?.workspace?.value,
metadata?.workspace?.value,
metadata,
);

Expand All @@ -77,15 +73,6 @@ export function WorkspaceOauthFlow({
setShowURL(false);
}, [setShowURL]);

const setSalesforceWorkspace = (workspace: string) => {
setWorkspace(workspace);
setFormData((prev) => ({ ...prev, workspace: workspace }));
setMetadata((prev) => ({
...prev,
workspace: { value: workspace, source: "input" },
}));
};

const handleFormDataChange = (key: string, value: string) => {
setFormData((prev) => ({ ...prev, [key]: value }));
setMetadata((prev) => ({ ...prev, [key]: { value, source: "input" } }));
Expand All @@ -106,28 +93,19 @@ export function WorkspaceOauthFlow({
}
};

// custom entry component for Salesforce provider
const workspaceEntryComponent =
provider === PROVIDER_SALESFORCE ? (
<SalesforceSubdomainEntry
handleSubmit={providerHandleSubmit}
setWorkspace={setSalesforceWorkspace}
error={errorMessage}
isButtonDisabled={workspace.length === 0}
/>
) : (
// general workspace entry component
<WorkspaceEntryContent
handleSubmit={providerHandleSubmit}
setFormData={handleFormDataChange}
error={errorMessage}
isButtonDisabled={
!isProviderMetadataValid(metadataInputs, formData) || isLoading
}
providerName={providerName}
metadataInputs={metadataInputs}
/>
);
// general workspace entry component
const workspaceEntryComponent = (
<WorkspaceEntryContent
handleSubmit={providerHandleSubmit}
setFormData={handleFormDataChange}
error={errorMessage}
isButtonDisabled={
!isProviderMetadataValid(metadataInputs, formData) || isLoading
}
providerName={providerName}
metadataInputs={metadataInputs}
/>
);

return (
<OAuthWindow
Expand Down