-
Notifications
You must be signed in to change notification settings - Fork 4
chore: rename moduleDependencies to dependentModules #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames moduleDependencies to dependentModules across the codebase and introduces a new DependentModule type with an optional boolean field. However, it includes substantially more than just a rename - it contains logic changes and numerous unrelated generated API updates.
Key changes:
- Renamed
moduleDependenciesproperty todependentModulesin metadata models - Introduced new
DependentModuletype to replace the genericobjecttype - Modified
filterMetadataByModulelogic to handle theoptionalflag (fields withoptional: trueare now excluded)
Reviewed Changes
Copilot reviewed 3 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/auth/providerMetadata.ts | Updated function to use dependentModules property and added new filtering logic for optional flag |
| src/components/Configure/layout/ProtectedConnectionLayout.tsx | Updated comment to reference dependentModules instead of moduleDependencies |
| src/components/auth/Oauth/ClientCredentials/ClientCredentialsContent.tsx | Minor formatting change to multi-line ternary expression (unrelated to PR purpose) |
| generated-sources/api/src/models/MetadataItemInput.ts | Renamed moduleDependencies to dependentModules with proper DependentModule type |
| generated-sources/api/src/models/MetadataItemPostAuthentication.ts | Renamed moduleDependencies to dependentModules with proper DependentModule type |
| generated-sources/api/src/models/DependentModule.ts | New type definition with optional boolean field |
| generated-sources/api/src/models/index.ts | Added exports for new types including unrelated notification/topic models |
| generated-sources/api/src/models/Oauth2Opts.ts | Added unrelated scopeMappings field |
| generated-sources/api/src/models/CreateTopicRequest.ts | Changed label field to name field |
| generated-sources/api/src/models/UpdateTopicRequest.ts | Updated comment from "notification topic" to "topic" |
| generated-sources/api/src/models/*.ts (multiple notification/topic files) | New generated files for notification and topic functionality (unrelated to rename) |
| generated-sources/api/src/apis/NotificationApi.ts | Extensive refactoring with method reordering and URL path changes (unrelated) |
| generated-sources/api/src/apis/DestinationApi.ts | Added new topic-related methods (unrelated) |
| generated-sources/api/.openapi-generator/FILES | Updated file list to include new generated models |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| metadata.displayName || | ||
| capitalize(metadata.name.toLowerCase()) |
Copilot
AI
Nov 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This formatting change (splitting the ternary expression across lines) appears unrelated to the PR's stated purpose of renaming moduleDependencies to dependentModules. Consider removing this change or documenting why it was included in this PR.
| metadata.displayName || | |
| capitalize(metadata.name.toLowerCase()) | |
| metadata.displayName || capitalize(metadata.name.toLowerCase()) |
Testing