Skip to content

Conversation

@immdipu
Copy link
Collaborator

@immdipu immdipu commented Dec 24, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 24, 2025 06:58
@immdipu immdipu requested review from RajatPawar and removed request for Copilot December 24, 2025 07:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the deep connector Copilot instructions by consolidating two similar chatmode configuration files and adding comprehensive patterns and templates for documenting connector capabilities.

Key Changes:

  • Deleted the duplicate ampersand-doc.chatmode.md file (180 lines removed)
  • Enhanced ampersand-docs.chatmode.md with detailed formatting patterns for deep connectors
  • Standardized heading capitalization (e.g., "What's supported", "Example integration", "Before you get started")
  • Added new sections with explicit templates for Read/Write/Subscribe/Proxy action documentation patterns

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/chatmodes/ampersand-docs.chatmode.md Updated deep connector definition, standardized heading capitalization, improved indentation consistency, and added ~140 lines of detailed formatting patterns and templates for documenting connector actions and capabilities
.github/chatmodes/ampersand-doc.chatmode.md Removed duplicate chatmode file (entire 180-line file deleted)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Start using connector & conditional bullets for each capability (Read → webhook messages, Write → call Write API, Proxy → make Proxy API calls, Subscribe → receive event webhooks).
8. (Optional) H2 Customer guide linking to `/customer-guides/<slug>` if such file exists.
9. (Optional) H2 API documentation for upstream docs if not already heavily linked.
4. H3 "Example integration" containing a minimal amp.yaml snippet: specVersion, integration name (use camelCase like `providerIntegration`), displayName, provider slug, and action blocks (read/write/subscribe/proxy) only for capabilities supported. If only proxy: show proxy.enabled: true. If read/write: show read.objects with example objectName entries; keep concise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contradiction with Example Integration Section Pattern: Line 28 states the section should contain "a minimal amp.yaml snippet" but lines 204-211 define the pattern as only containing a link to the samples repo ("The 'Example integration' section is always the same format for all providers - just a link to the samples repo"). This creates conflicting instructions that will lead to inconsistent documentation generation.

# Fix: Update line 28 to match the pattern
4. H3 "Example integration" containing a link to the sample manifest file in the samples repo...
Suggested change
4. H3 "Example integration" containing a minimal amp.yaml snippet: specVersion, integration name (use camelCase like `providerIntegration`), displayName, provider slug, and action blocks (read/write/subscribe/proxy) only for capabilities supported. If only proxy: show proxy.enabled: true. If read/write: show read.objects with example objectName entries; keep concise.
4. H3 "Example integration" containing a link to the sample manifest file in the samples repo.

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants