-
Notifications
You must be signed in to change notification settings - Fork 6
[CON-2760] feat: Add Cisco Webex #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Cobalt0s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
laurenzlong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts:
- this provider should simply called
webex, notciscoWebex, since webex is a recognizable name, and we prefer shorter and simpler provider names where-ever possible - this doc doesn't have any screenshots or gifs that show users how to create the Webex app
Ok, I knew about the shorter naming, but I thought it would be important to include Cisco. My bad. |
9cf5952 to
14c499c
Compare
Changes made, thanks for the guidance. Let me know if the GIF look good or if anything else needs adjusting. |
|
|
||
| 9. Click **Add Integration**. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gif is missing the mouse cursor so in the first steps it looks like jumping. But that is my preference.
| - [events](https://developer.webex.com/docs/api/v1/events/list-events) (Read only) | ||
| - [organizations](https://developer.webex.com/docs/api/v1/organizations/list-organizations) (Read only) | ||
| - [reports](https://developer.webex.com/admin/docs/api/v1/reports/list-reports) (Read only) | ||
| - [meetings](https://developer.webex.com/meeting/docs/meetings) (Read,Write) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think meetings can be accessed with ordinary user level account.
Some objects require organization-level admin scopes, while others can be accessed with user-level scopes. I think we should mention this in some way.
Admin API is a superset. Maybe there are some Webex docs that we can point out customers to decide what account type do they need. You have a <Note> below which is helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Read,Write) is missing space, unlike other lines.
| ### Creating a Webex Integration | ||
|
|
||
| <Note> | ||
| The Admin Suite integration requires organization-level access in Cisco Webex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the comment above, maybe link some docs about Admin Suite integration.
Description
Adds documentation for the Cisco Webex connector, including setup instructions, supported actions, and supported objects from the Admin
Screenshot