Update styles and split out parse logic into methods#5
Open
sumpygump wants to merge 11 commits intoamnuts:masterfrom
Open
Update styles and split out parse logic into methods#5sumpygump wants to merge 11 commits intoamnuts:masterfrom
sumpygump wants to merge 11 commits intoamnuts:masterfrom
Conversation
added 11 commits
June 23, 2018 09:49
Author
|
Any interest in this? |
Owner
|
Wow, @sumpygump, I am so sorry! I must have completely misses this PR and your comment... I honestly didn't think anyone used this script. :-) I'm a bit busy for this upcoming week, but I'll take a look at it after that and let you know... You've very kindly waited five years for a response (<gulp, blush>), so hopefully one more week isn't too bad! |
Author
|
No worries! I figured other things took priority. I was just going through my forks and PRs and noticed this one and was just curious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me first say this project is pretty cool. I like the simplicity and effectiveness for viewing the PHP error log in this manner. I have been using it a while and decided to make a few style updates. I also was troubleshooting an issue and broke out the logic of parsing the logs into individual methods in a class to help me root out the problem. I think it will be a benefit for future features too.