Browser detection, settings stored across sessions, ux changes for attribution#19
Open
Ethicmeta wants to merge 4 commits intoamitness:devfrom
Open
Browser detection, settings stored across sessions, ux changes for attribution#19Ethicmeta wants to merge 4 commits intoamitness:devfrom
Ethicmeta wants to merge 4 commits intoamitness:devfrom
Conversation
Author
|
@amitness with the vast difference in changes, I removed the use of attribution in the usersettings.html. The functionality still exists in inject.js so all we'll have to do is add the html elements to handle attribution if we want it to. (note, this is only for the copy pasted part and works independently of the url being stored in the history table.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added browser detection (extremely basic. if browser object is undefined, it's chrome. otherwise treat it like firefox. this will probably have to change in the future to something like separate build folders entirely, but for now!) and handling storage for each browser.
added saved options. Change an option, end session, next session has the options populated from prev session.
relocated attribution block to beginning of code. ex: