This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Open
Conversation
MAC install script created ".attendance" in wrong place when multiple users exist and current user is not admin.
Contributor
|
Thank you for contributing to this project, we will soon review this pull request. 👍 |
vibhoothi
suggested changes
Oct 13, 2019
Contributor
vibhoothi
left a comment
vibhoothi
left a comment
There was a problem hiding this comment.
HI @Oxyde2 ,
Super thanks for this patch,
I would advise @AnandHemachandran, who did the first patch send for this to incoperate this as second patch to overall patchset once the change requested is addressed which should make the progress improved.
| elif _platform == "darwin": | ||
| file_path = f"/Users/{sys.argv[1]}/.attendance/" | ||
| elif "win" in _platform: | ||
| file_path = getcwd()+'\\' |
Contributor
There was a problem hiding this comment.
Okay,
We should have a folder for storing the script right,
I would propose to have it in a folder itself like .attendance for having uniformity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help advance #2 ...
I don't know if the batch is perfect though.
-Oxyde