Upgrade specs-physics to latest nphysics#31
Merged
AnneKitsune merged 1 commit intoamethyst:masterfrom Apr 29, 2020
Merged
Conversation
|
It looks like there's a slightly newer version of n{physics,collide,algebra} available, and upgrading to those doesn't break the build at least: diff --git a/Cargo.toml b/Cargo.toml
index 8baa02c..b547f0c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -20,12 +20,12 @@ amethyst = ["amethyst_core"]
[dependencies]
log = "0.4.6"
specs = "0.16.0"
specs-hierarchy = "0.6.0"
shrev = "1.1.1"
-nalgebra = "0.19.0"
-ncollide3d = "0.21.0"
-nphysics3d = "0.13.1"
+nalgebra = "0.20"
+ncollide3d = "0.22"
+nphysics3d = "0.14"
amethyst_core = { git = "https://github.com/amethyst/amethyst", optional = true }
objekt = "0.1.2"
|
|
That does end up pulling in a different version of nalgebra from what crates.io Amethyst is currently using unfortunately, so maybe it's not the best idea to integrate it into this PR. |
Contributor
Author
|
That's right, I specifically chose the n* crate versions for compatibility with Amethyst. |
Contributor
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 29, 2020
31: Upgrade specs-physics to latest nphysics r=jojolepro a=willcrichton Since #23 seems to have stagnated, I went ahead and updated specs-physics to the latest nalgebra/nphysics versions. It passes all the tests in the repo, but I haven't attempted a larger integration into Amethyst yet. Co-authored-by: Will Crichton <wcrichto@cs.stanford.edu>
This was referenced Apr 29, 2020
|
Timed out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #23 seems to have stagnated, I went ahead and updated specs-physics to the latest nalgebra/nphysics versions. It passes all the tests in the repo, but I haven't attempted a larger integration into Amethyst yet.